Skip to content

feat(vortex-geo): add Hilbert scalar function - #9239

Open
HarukiMoriarty wants to merge 1 commit into
nemo/geo-intersection-nativefrom
nemo/geo-hilbert-bounds
Open

feat(vortex-geo): add Hilbert scalar function#9239
HarukiMoriarty wants to merge 1 commit into
nemo/geo-intersection-nativefrom
nemo/geo-hilbert-bounds

Conversation

@HarukiMoriarty

@HarukiMoriarty HarukiMoriarty commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add vortex.geo.hilbert for native geometry columns with constant Rect bounds
  • reuse the existing GeoEnvelope kernel and unary constant/column dispatch
  • return nullable u32 Hilbert keys for spatial clustering
  • add point and multipolygon Divan benchmarks

@HarukiMoriarty HarukiMoriarty added the changelog/feature A new feature label Aug 6, 2026
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-hilbert-bounds branch from 00fa457 to c0d4338 Compare August 6, 2026 14:41
@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 1956 untouched benchmarks
🆕 13 new benchmarks
⏩ 89 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation cold_misaligned[(64, 256)] 4.4 ms 5.3 ms -16.99%
⚡ Simulation decode_varbin[(1000, 2)] 78.5 µs 62.6 µs +25.43%
⚡ Simulation decompress[u64, (1000, 16)] 73.6 µs 65 µs +13.16%
🆕 Simulation linestrings N/A 167.9 µs N/A
🆕 Simulation nullable_points N/A 345.1 µs N/A
🆕 Simulation points N/A 165.5 µs N/A
🆕 Simulation polygons N/A 167.8 µs N/A
🆕 Simulation eight_points N/A 3.7 ms N/A
🆕 Simulation nullable_eight_points N/A 3.7 ms N/A
🆕 Simulation sixty_four_points N/A 16.2 ms N/A
🆕 Simulation nullable_rectangles N/A 12.5 ms N/A
🆕 Simulation rectangles N/A 13.4 ms N/A
🆕 Simulation thirty_two_vertex_boundaries N/A 52.7 ms N/A
🆕 Simulation envelope_of_collected_points N/A 488.7 µs N/A
🆕 Simulation multipolygons N/A 1.2 ms N/A
🆕 Simulation points N/A 197.7 µs N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing nemo/geo-hilbert-bounds (135eaa8) with develop (ff0a26d)2

Open in CodSpeed

Footnotes

  1. 89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on nemo/geo-intersection-native (d84c82b) during the generation of this report, so develop (ff0a26d) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-hilbert-bounds branch from c0d4338 to 2bf6598 Compare August 6, 2026 17:58
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-hilbert-bounds branch from 2bf6598 to 1918865 Compare August 6, 2026 20:13
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-hilbert-bounds branch from 1918865 to 1d52139 Compare August 6, 2026 20:16
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-hilbert-bounds branch from 1d52139 to d90dc7c Compare August 7, 2026 13:52
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-hilbert-bounds branch from d90dc7c to 2794d68 Compare August 7, 2026 14:44
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-hilbert-bounds branch from 2794d68 to 16a0c6e Compare August 10, 2026 18:14
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-hilbert-bounds branch from 16a0c6e to 135eaa8 Compare August 10, 2026 18:16
@HarukiMoriarty
feat(geo): add Hilbert scalar function
bf07ac2 
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-hilbert-bounds branch from 135eaa8 to bf07ac2 Compare August 10, 2026 19:50
@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog/feature A new feature stale This PR is stale and will be auto-closed soon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HarukiMoriarty